https://github.com/qedawkins commented: Nits/typos. New callbacks make sense, though see the comment about moving scf.for/forall to use the same mechanism and moving the code out of SCF in the future. https://github.com/llvm/llvm-project/pull/159660