[Mlir-commits] [mlir] [MLIR] Move the `mlir-generate-reproducer` option to be a PassManager option instead of mlir-opt (PR #159004)

[Jacques Pienaar]

================
@@ -282,6 +282,11 @@ class PassManager : public OpPassManager {
   /// Add the provided instrumentation to the pass manager.
   void addInstrumentation(std::unique_ptr<PassInstrumentation> pi);
 
+  /// Enable or disable the printing of pass manager reproducer.
+  void enableGeneratePassManagerReproducer(std::string filename) {
----------------
jpienaar wrote:

We already have https://github.com/llvm/llvm-project/blob/332eb5f693d2e28026aaa4f580cef607898ed756/mlir/lib/Pass/PassCrashRecovery.cpp#L466 one the pass manager. And that can be set with either stream or filename. So this is really about adding an option so that it would generate a reproducer even if no error occurred, is that correct? (the filename or stream setting is independent really).  And you want that per pipeline? (e.g., in PassInstrumentation equivalent would be to generate in runBeforePipeline). And potentially additionally into a different place than where the crash reproducer would go?

https://github.com/llvm/llvm-project/pull/159004