[Mlir-commits] [mlir] [MLIR] Add option to postpone remark emission (PR #157434)

[Guray Ozen]

grypp wrote:

> Right, so back to the question: I still don't see why the emitter of the remark should know about this,

At the point of emission, you know whether the `Remark` should be postponed or not — for example, if you know a later pass will attempt to optimize this op again. If postponing is handled entirely in the callback, how would it know *which* remarks to postpone and which not to?

If I’m missing something, could you show me a draft of the code? I’d be happy to adjust my approach.

> and as such I don't understand why the concept of "postpone" belongs to the remark itself.
fwiw, this PR makes `postponing` a trait of `RemarkEngine`, not the `Remark` class.

My impression is that @razvanlupusoru wants to postpone every remark by default — if that’s the case, we could add a `postponeAll` flag to `RemarkEngine`.

https://github.com/llvm/llvm-project/pull/157434