[Mlir-commits] [mlir] [MLIR] Add option to postpone remark emission (PR #157434)

[Guray Ozen]

grypp wrote:

> Thank you Guray for your continued contributions in this area. The functionality to postpone remarks is great as I want this as well :) However, it feels a bit strange that "postponed" is a property of the Remark itself - it seems more natural if this was a setting of the RemarkEngine to collect everything until either "reportAll" is called or RemarkEngine is destroyed.

Hmm, are you suggesting making postponing part of the `RemarkEngine` and applying it to every remark? We can have this. But having this only on the `RemarkEngine` is coarse, then you wouldn’t be able to differentiate which remarks to postpone and which not to. 

Postponing remarks can be costly because the `RemarkEngine` has to keep them in memory. So I thought if you know a remark won’t change, you shouldn’t postpone it.

How is your use-case? For Flang, do you want to postpone every remark? 


https://github.com/llvm/llvm-project/pull/157434