[Mlir-commits] [mlir] [MLIR] getBackwardSlice: don't bail on ops that are IsolatedFromAbove (PR #158135)

[Oleksandr Alex Zinenko]

ftynse wrote:

I was thinking  here https://github.com/llvm/llvm-project/blob/370607065d65d4cd65bf455fcf2de12576d8e272/mlir/lib/Analysis/SliceAnalysis.cpp#L141 (but not here https://github.com/llvm/llvm-project/blob/370607065d65d4cd65bf455fcf2de12576d8e272/mlir/lib/Analysis/SliceAnalysis.cpp#L125 IIUC) so we don't recurse into this function for an isolated-from-above _parent_ of the current, but we include the isolated-from-above defining op and continue to its operands.

Incidentally, we shouldn't be recursing on the use-def chain because those tend to be long and stack tends to be small, but that is a follow-up.

https://github.com/llvm/llvm-project/pull/158135