[Mlir-commits] [llvm] [mlir] [LLVM][MLIR] Move LSP server support library from MLIR into LLVM (PR #157885)

[Michał Górny]

mgorny wrote:

I think I see a potential cause:

```
[2193/2323] : && /usr/lib/ccache/bin/aarch64-unknown-linux-gnu-g++ -O2 -pipe -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wimplicit-fallthrough -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs    -Wl,-rpath-link,/var/tmp/portage/llvm-core/mlir-22.0.0.9999/work/mlir_build-.arm64/./lib64  -Wl,--gc-sections  -Wl,--dependency-file=tools/mlir-pdll-lsp-server/CMakeFiles/mlir-pdll-lsp-server.dir/link.d tools/mlir-pdll-lsp-server/CMakeFiles/mlir-pdll-lsp-server.dir/mlir-pdll-lsp-server.cpp.o -o bin/mlir-pdll-lsp-server  -Wl,-rpath,"\$ORIGIN/../lib64:/usr/lib/llvm/22/lib64:"  lib64/libMLIRPdllLspServerLib.a  lib64/libMLIRPDLLCodeGen.a  lib64/libMLIRParser.a  lib64/libMLIRBytecodeReader.a  lib64/libMLIRAsmParser.a  lib64/libMLIRPDLDialect.a  lib64/libMLIRInferTypeOpInterface.a  lib64/libMLIRSideEffectInterfaces.a  lib64/libMLIRIR.a  lib64/libMLIRPDLLParser.a  lib64/libMLIRPDLLAST.a  lib64/libMLIRPDLLODS.a  lib64/libMLIRTableGen.a  /usr/lib/llvm/22/lib64/libLLVMTableGen.a  /usr/lib/llvm/22/lib64/libLLVMSupport.a  -lrt  -ldl  -lm  /usr/lib64/libz3.so  /usr/lib64/libz.so  /usr/lib64/libzstd.so  /usr/lib/llvm/22/lib64/libLLVMDemangle.a  lib64/libMLIRLspServerSupportLib.a  lib64/libMLIRSupport.a  /usr/lib/llvm/22/lib64/libLLVM.so.22.0git5c717105 && :
```

`mlir-pdll-lsp-server` ends up linking to `libLLVM*.a` and `libLLVM.so` simultaneously, which is bound to create random corruption.

https://github.com/llvm/llvm-project/pull/157885