[Mlir-commits] [mlir] [MLIR] Make 1-D memref flattening a prerequisite for vector narrow type emulation (PR #157771)

[Andrzej Warzyński]

================
@@ -0,0 +1,64 @@
+// RUN: mlir-opt --test-memref-flatten-and-vector-narrow-type-emulation --split-input-file %s | FileCheck %s
+
+// This test verifies that narrow-type-emulation works correctly for
+// rank > 1 memrefs by combining memref flattening with vector narrow type
+// emulation patterns. 
+//
+// The patterns tested here demonstrate the composition of two transformations,
+// memref flattening for vector ops and vector op narrow type emulation.
+//
+// TODO: Support `vector.transfer_write` operation.
+
+func.func @vector_load_2d_i4(%arg0: index, %arg1: index) -> vector<8xi4> {
----------------
banach-space wrote:

1. Single index argument should be sufficient, right? (you can re-use it).
2. Use more descriptive names.
3. Similar comment for other tests.
```suggestion
func.func @vector_load_2d_i4(%idx: index) -> vector<8xi4> {
```

https://github.com/llvm/llvm-project/pull/157771