[Mlir-commits] [mlir] [mlir][arith][NFC] Minor Revisions to Comments (PR #158757)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Mon Sep 15 16:58:50 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-arith
Author: Akhil Goel (akhilgoe)
<details>
<summary>Changes</summary>
This is a minor nitpick PR to fix a few comments.
---
Full diff: https://github.com/llvm/llvm-project/pull/158757.diff
2 Files Affected:
- (modified) mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td (+1-1)
- (modified) mlir/lib/Dialect/Arith/IR/ArithOps.cpp (+1-1)
``````````diff
diff --git a/mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td b/mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td
index 4558d827e8563..de3efc9fe3506 100644
--- a/mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td
+++ b/mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td
@@ -394,7 +394,7 @@ def TruncIShrSIToTrunciShrUI :
[(TruncationMatchesShiftAmount $x, $tr, $c0)]>;
//===----------------------------------------------------------------------===//
-// TruncIOp
+// TruncFOp
//===----------------------------------------------------------------------===//
// truncf(sitofp(x)) -> sitofp(x) if default rounding mode.
diff --git a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
index 7d4d818ee448b..503507a4ecfed 100644
--- a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
+++ b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
@@ -2723,7 +2723,7 @@ TypedAttr mlir::arith::getIdentityValueAttr(AtomicRMWKind kind, Type resultType,
return nullptr;
}
-/// Return the identity numeric value associated to the give op.
+/// Return the identity numeric value associated to the given op.
std::optional<TypedAttr> mlir::arith::getNeutralElement(Operation *op) {
std::optional<AtomicRMWKind> maybeKind =
llvm::TypeSwitch<Operation *, std::optional<AtomicRMWKind>>(op)
``````````
</details>
https://github.com/llvm/llvm-project/pull/158757
More information about the Mlir-commits
mailing list