[Mlir-commits] [mlir] [mlir][spirv] Update spirv validation for module.mlir (PR #158678)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Igor Wodiany (IgWod-IMG)

<details>
<summary>Changes</summary>

This is to check that the new `spirv-val` behaviour works correctly. Subsequent PRs will add validation to other target tests. This requires the most recent SPIRV-Tools to work (for existing build directories that use bundled SPIR-V tools `SPIRVTools-update` cmake target should do the trick).

---
Full diff: https://github.com/llvm/llvm-project/pull/158678.diff


1 Files Affected:

- (modified) mlir/test/Target/SPIRV/module.mlir (+1-1) 


``````````diff
diff --git a/mlir/test/Target/SPIRV/module.mlir b/mlir/test/Target/SPIRV/module.mlir
index d4000dfa53810..7e52e549b5266 100644
--- a/mlir/test/Target/SPIRV/module.mlir
+++ b/mlir/test/Target/SPIRV/module.mlir
@@ -4,7 +4,7 @@
 // RUN: %if spirv-tools %{ rm -rf %t %}
 // RUN: %if spirv-tools %{ mkdir %t %}
 // RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}
-// RUN: %if spirv-tools %{ ls %t/module*.spv | xargs -I{} spirv-val {} %}
+// RUN: %if spirv-tools %{ spirv-val %t %}
 
 // CHECK:      spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
 // CHECK-NEXT:   spirv.func @foo() "Inline" {

``````````

</details>


https://github.com/llvm/llvm-project/pull/158678