[Mlir-commits] [mlir] [mlir][linalg] convert arith ops to destination-passing-style. (PR #157854)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

I would suggest creating a new test file with Arith Ops. I see two reasons:
* Separate tests for `Tensor` and `Arith` Ops (these trigger different patterns, so separating them makes sense IMHO).
* For `Tensor` Ops, the naming scheme for test functions is `@tensor_<op-name>_variant`. For `Arith`, you are using `@arith_<binary|unary>_op`. So that's a bit inconsistent.

If you prefer to keep everything in one file, could you add a big comment separating `Tensor` and `Arith` Ops? Here's an example block comment: https://github.com/llvm/llvm-project/blob/5437d90bb72e38ad767dd2e130d23675130a7857/mlir/test/Dialect/Linalg/vectorization/pad-with-patterns.mlir#L3-L5

https://github.com/llvm/llvm-project/pull/157854