https://github.com/superbobry approved this pull request. Looks good, but I think it would be more helpful to have op-specific subtypes instead of just `ir.Attribute` for attributes. https://github.com/llvm/llvm-project/pull/158455