[Mlir-commits] [mlir] [mlir][vector] Fix crash in vector.from_elements folding with poison values (PR #158528)

[Yang Bai]

yangtetris wrote:

Thanks for fixing the issue. I didn't consider this comprehensively when moving the conversion logic to a separate function.

I'm wondering if we could fix this in another way:
1. Change the parameter type of `convertIntegerAttr` to `IntegerAttr`.
2. Expand the `!attr` check at the beginning of `foldFromElementsToConstant` to handle poison attrs.

Given that the function name is already **convertIntegerAttr**, it seems like ensuring the type should be the caller's responsibility.

https://github.com/llvm/llvm-project/pull/158528