[Mlir-commits] [mlir] [MLIR] getBackwardSlice: don't bail on ops that are IsolatedFromAbove (PR #158135)

[Ian Wood]

IanWood1 wrote:

> When getBackwardSliceImpl hits an isolated-from-above op, it doesn't need to go any further because there cannot be any values in the backward slice due to isolation.

If it is isolated we should still add it to the slice and traverse the operands. However, the trait tells us that the op's regions don't access any values outside. So, do you mean the check should be moved here: https://github.com/llvm/llvm-project/blob/370607065d65d4cd65bf455fcf2de12576d8e272/mlir/lib/Analysis/SliceAnalysis.cpp#L153



https://github.com/llvm/llvm-project/pull/158135