[Mlir-commits] [flang] [mlir] [Flang][mlir] - Translation of delayed privatization for deferred target-tasks (PR #155348)

[Pranav Bhandarkar]

================
@@ -18,4 +19,5 @@ add_mlir_dialect_library(MLIRLLVMIRTransforms
   MLIRPass
   MLIRTransforms
   MLIRNVVMDialect
+  MLIROpenMPDialect
----------------
bhandarkar-pranav wrote:

> Huh I wonder if it works because Transforms is different to the LLVMIR dialect itself?

Yes, i think that's right. `MLIRLLVMIRTransforms` is its own library and the dependency chain is
`MLIRLLVMIRTransforms` -> `MLIROpenMPDialect` -> `MLIRLLVMIRDialect`
`MLIRLLVMIRTRransforms` -> `MLIRLLVMIRDialect`

> Even if it isn't a strict circular dependency, I don't know if this is good design. Could the pass live in the OpenMP dialect instead?

It could, I am open to changing where the pass lives. IIRC, this location wasn't my first choice. However, i do not remember why I finally decided to put this in the LLVMIR Dialect.  Let me explore some options; OpenMP dialect is a good place too.

https://github.com/llvm/llvm-project/pull/155348