[Mlir-commits] [mlir] [MLIR] Make 1-D memref flattening a prerequisite for vector narrow type emulation (PR #157771)

[Andrzej Warzyński]

================
@@ -383,6 +383,12 @@ void populateVectorNarrowTypeEmulationPatterns(
     const arith::NarrowTypeEmulationConverter &typeConverter,
     RewritePatternSet &patterns, bool disableAtomicRMW = false);
 
+/// Populates patterns for both memref flattening and vector narrow type
+/// emulation.
----------------
banach-space wrote:

Expand a bit so that the rationale is clear.

```suggestion
/// Populates patterns for both MeMref flattening and Vector narrow type
/// emulation.
///
/// Patterns for narrow-type-emulation require "flattened" MemRef(s), so this composite populate* method can be used for narrow-type-emulation for Ops operating on  MemRef(s) that are rank > 2.
```

https://github.com/llvm/llvm-project/pull/157771