[Mlir-commits] [mlir] [mlir][lsp] Downgrade unregistered dialect error. (PR #143346)

[Mehdi Amini]

================
@@ -231,6 +231,17 @@ static lsp::Diagnostic getLspDiagnoticFromDiag(llvm::SourceMgr &sourceMgr,
   }
   lspDiag.message = diag.str();
 
+  // Downgrade errors related to unregistered dialects. We want to be able to
+  // provide the user with headsup about why the file didn't parse, but it is
+  // not an error in the same way invalid syntax or op that failed verification
+  // is. Chose to make it a warning rather than information as it could be due
+  // to typo (and so addressable by the user).
----------------
joker-eph wrote:

I don't quite get this: an invalid syntax is even more likely to be a typo and so addressable by the user, the argument reads backward to me here.

https://github.com/llvm/llvm-project/pull/143346