[Mlir-commits] [mlir] [MLIR] getBackwardSlice: don't bail on ops that are IsolatedFromAbove (PR #158135)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Ian Wood (IanWood1)

<details>
<summary>Changes</summary>

Ops with the `IsIsolatedFromAbove` trait can still have operands that would be useful to capture in the backwards slice.

---
Full diff: https://github.com/llvm/llvm-project/pull/158135.diff


1 Files Affected:

- (modified) mlir/lib/Analysis/SliceAnalysis.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/Analysis/SliceAnalysis.cpp b/mlir/lib/Analysis/SliceAnalysis.cpp
index 7037fa644c7be..d0e10626589ce 100644
--- a/mlir/lib/Analysis/SliceAnalysis.cpp
+++ b/mlir/lib/Analysis/SliceAnalysis.cpp
@@ -109,7 +109,7 @@ static LogicalResult getBackwardSliceImpl(Operation *op,
                                           DenseSet<Operation *> &visited,
                                           SetVector<Operation *> *backwardSlice,
                                           const BackwardSliceOptions &options) {
-  if (!op || op->hasTrait<OpTrait::IsIsolatedFromAbove>())
+  if (!op)
     return success();
 
   // Evaluate whether we should keep this def.

``````````

</details>


https://github.com/llvm/llvm-project/pull/158135