[Mlir-commits] [mlir] [MLIR] Add debug log to the pass manager (NFC) (PR #156205)

[Andrzej Warzyński]

banach-space wrote:

> What's actually missing for folks who who read a PR in the future?

The history of these changes and how our discussion here shaped it. Phabricator did preserve the intermediate diffs - that isn’t available here anymore.

This may feel unnecessary today, but it could be very valuable in the future. From my experience working on Flang and digging through Clang’s history, I learnt the hard way that these review discussions can be a very valuable source of information for our “future” selves and other contributors.

> After the split from the infrastructure part, I'm not sure if someone still want to review this?

I’ve skimmed through and it mostly looks good. One thing I’d appreciate is some high-level documentation/rationale for what the different logging levels represent. Otherwise, the distinctions could feel a bit arbitrary to future readers. Not a blocker, just a nice-to-have.

Thanks!

https://github.com/llvm/llvm-project/pull/156205