[Mlir-commits] [mlir] [MLIR][SideEffects][MemoryEffects] Modified LICM to be more aggressive when checking movability of ops with MemWrite effects (PR #155344)

[Uday Bondhugula]

================
@@ -21,6 +23,17 @@ class Region;
 class RewriterBase;
 class Value;
 
+/// Gathers potential conflicts on all memory resources used within loop
+///
+/// Given a target loop and an op within it (or the loop op itself), 
+/// gathers op's memory effects and flags potential resource conflicts 
+/// in a map and then recurses into the op's regions to gather nested 
+/// resource conflicts 
+///
+/// First call should use loop = someLoop and op = someLoop.getOperation()
----------------
bondhugula wrote:

Punctuate properly (full stop at the end) - per LLVM stye. Document output argument better. Avoid mixing up implementation details.

https://github.com/llvm/llvm-project/pull/155344