[Mlir-commits] [flang] [mlir] [Flang][mlir] - Translation of delayed privatization for deferred target-tasks (PR #155348)

[Pranav Bhandarkar]

================
@@ -0,0 +1,23 @@
+//===- OpenMPOffloadPrivatizationPrepare.h - Prepare for OpenMP Offload
+// Privatization -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef MLIR_DIALECT_LLVMIR_TRANSFORMS_PREPAREFOROMPOFFLOADPRIVATIZATIONPASS_H
----------------
bhandarkar-pranav wrote:

> If you would like to refactor Passes.h to not include all passes you could do that. But if you don't, you pass is being declared in two header files. If at some point in the future a translation unit is to include both, you will get a declaration conflict. 
No, my solution would be to delete `OpenMPOffloadPrivatizationPrepare.h` and rely on Passes.h entirely.

>IMHO the compile-time saving of have to 5 fewer pass declarations to parse in `OpenMPOffloadPrivatizationPrepare.h.h` is not worth the hassle of diverging from common practice of having only one header for each think (other than forward-declarations).

Noted.


https://github.com/llvm/llvm-project/pull/155348