[Mlir-commits] [mlir] [mlir][vector] Propagate alignment when emulating masked{load, stores}. (PR #155648)

Kunwar Grover llvmlistbot at llvm.org
Mon Sep 8 00:23:56 PDT 2025


Groverkss wrote:

> This has landed without an explicit approval. Please note that we do require explicit approvals in LLVM:
> 
> * https://llvm.org/docs/GitHub.html#approvals
> 
> This change LGTM, so this is also a note to myself to be more explicit next time. Thanks for contributing!

I don't know if we have to be super strict about how a rule is enforced. LLVM allows post-review commit for small, trivial patches (like this one). A passing by comment about code style shouldn't need an explicit approval IMO. Waiting for a small trivial change like this does have developer cost.

https://github.com/llvm/llvm-project/pull/155648


More information about the Mlir-commits mailing list