[Mlir-commits] [mlir] [mlir] Use free op create functions. NFC. (PR #157374)

Sun Sep 7 19:16:43 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-gcc` running on `as-builder-7` while building `mlir` at step 6 "build-flang-rt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/152/builds/4940

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-flang-rt) failure: cmake (failure)
...
31.930 [706/23/6358] Building CXX object tools/flang/lib/Support/CMakeFiles/FortranSupport.dir/Fortran-features.cpp.o
31.980 [706/22/6359] Building CXX object tools/flang/lib/Support/CMakeFiles/FortranSupport.dir/Version.cpp.o
31.995 [706/21/6360] Linking CXX static library lib/libclangCodeGen.a
32.028 [705/21/6361] Linking CXX static library lib/libclangFrontendTool.a
32.112 [705/20/6362] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRNVVMDialect.dir/IR/BasicPtxBuilderInterface.cpp.o
32.518 [704/20/6363] Linking CXX static library lib/libMLIRNVVMDialect.a
32.551 [702/21/6364] Linking CXX static library lib/libMLIRNVVMToLLVM.a
32.566 [702/20/6365] Linking CXX static library lib/libMLIRLLVMIRTransforms.a
32.621 [701/20/6366] Linking CXX static library lib/libMLIRTargetLLVMIRExport.a
32.632 [693/27/6367] Building CXX object tools/mlir/lib/Conversion/PtrToLLVM/CMakeFiles/obj.MLIRPtrToLLVM.dir/PtrToLLVM.cpp.o
FAILED: tools/mlir/lib/Conversion/PtrToLLVM/CMakeFiles/obj.MLIRPtrToLLVM.dir/PtrToLLVM.cpp.o 
ccache /usr/bin/g++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/build/tools/mlir/lib/Conversion/PtrToLLVM -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Conversion/PtrToLLVM -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/build/tools/mlir/include -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/include -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/build/include -I/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Wno-unused-but-set-parameter -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/mlir/lib/Conversion/PtrToLLVM/CMakeFiles/obj.MLIRPtrToLLVM.dir/PtrToLLVM.cpp.o -MF tools/mlir/lib/Conversion/PtrToLLVM/CMakeFiles/obj.MLIRPtrToLLVM.dir/PtrToLLVM.cpp.o.d -o tools/mlir/lib/Conversion/PtrToLLVM/CMakeFiles/obj.MLIRPtrToLLVM.dir/PtrToLLVM.cpp.o -c /home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Conversion/PtrToLLVM/PtrToLLVM.cpp
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Conversion/PtrToLLVM/PtrToLLVM.cpp: In member function ‘virtual llvm::LogicalResult {anonymous}::GetMetadataOpConversion::matchAndRewrite(mlir::ptr::GetMetadataOp, mlir::ConvertOpToLLVMPattern<mlir::ptr::GetMetadataOp>::OpAdaptor, mlir::ConversionPatternRewriter&) const’:
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Conversion/PtrToLLVM/PtrToLLVM.cpp:249:35: error: call of overloaded ‘create(mlir::ConversionPatternRewriter&, mlir::Location&, mlir::Value&, mlir::Value, int64_t)’ is ambiguous
  249 |   sV = LLVM::InsertValueOp::create(
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  250 |       rewriter, loc, sV, descriptor.allocatedPtr(rewriter, loc), int64_t{0});
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h:95,
                 from /home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Conversion/PtrToLLVM/PtrToLLVM.cpp:16:
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/build/tools/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.h.inc:14380:24: note: candidate: ‘static mlir::LLVM::InsertValueOp mlir::LLVM::InsertValueOp::create(mlir::OpBuilder&, mlir::Location, mlir::Value, mlir::Value, mlir::DenseI64ArrayAttr)’
14380 |   static InsertValueOp create(::mlir::OpBuilder &builder, ::mlir::Location location, ::mlir::Value container, ::mlir::Value value, ::mlir::DenseI64ArrayAttr position);
      |                        ^~~~~~
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/build/tools/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.h.inc:14389:24: note: candidate: ‘static mlir::LLVM::InsertValueOp mlir::LLVM::InsertValueOp::create(mlir::OpBuilder&, mlir::Location, mlir::Value, mlir::Value, llvm::ArrayRef<long int>)’
14389 |   static InsertValueOp create(::mlir::OpBuilder &builder, ::mlir::Location location, ::mlir::Value container, ::mlir::Value value, ::llvm::ArrayRef<int64_t> position);
      |                        ^~~~~~
32.656 [693/26/6368] Linking CXX static library lib/libMLIRBuiltinToLLVMIRTranslation.a
32.658 [693/25/6369] Linking CXX static library lib/libMLIRXeVMToLLVMIRTranslation.a
32.658 [693/24/6370] Linking CXX static library lib/libMLIROpenACCToLLVMIRTranslation.a
32.659 [693/23/6371] Linking CXX static library lib/libMLIRTargetLLVM.a
32.664 [693/22/6372] Linking CXX static library lib/libMLIRNVVMToLLVMIRTranslation.a
32.666 [693/21/6373] Linking CXX static library lib/libMLIRROCDLToLLVMIRTranslation.a
32.672 [693/20/6374] Linking CXX static library lib/libMLIRLLVMToLLVMIRTranslation.a
32.674 [693/19/6375] Linking CXX static library lib/libMLIROpenMPToLLVMIRTranslation.a
32.726 [693/18/6376] Building AMDGPUGenCallingConv.inc...
33.310 [693/17/6377] Linking CXX executable bin/lli
33.763 [693/16/6378] Building CXX object tools/mlir/lib/Dialect/XeGPU/Transforms/CMakeFiles/obj.MLIRXeGPUTransforms.dir/XeGPUSubgroupDistribute.cpp.o
33.994 [693/15/6379] Building AMDGPUGenAsmWriter.inc...
34.619 [693/14/6380] Building CXX object tools/flang/lib/Optimizer/Dialect/CUF/Attributes/CMakeFiles/CUFAttrs.dir/CUFAttr.cpp.o
35.832 [693/13/6381] Building AMDGPUGenDAGISel.inc...
36.613 [693/12/6382] Building AMDGPUGenInstrInfo.inc...
37.538 [693/11/6383] Building AMDGPUGenGlobalISel.inc...
38.073 [693/10/6384] Building CXX object tools/mlir/lib/Dialect/XeGPU/Transforms/CMakeFiles/obj.MLIRXeGPUTransforms.dir/XeGPUWgToSgDistribute.cpp.o
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/XeGPU/Transforms/XeGPUWgToSgDistribute.cpp: In member function ‘virtual llvm::LogicalResult {anonymous}::WgToSgVectorBroadcastOp::matchAndRewrite(mlir::vector::BroadcastOp, mlir::OpConversionPattern<mlir::vector::BroadcastOp>::OneToNOpAdaptor, mlir::ConversionPatternRewriter&) const’:
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/XeGPU/Transforms/XeGPUWgToSgDistribute.cpp:508:53: warning: possibly dangling reference to a temporary [-Wdangling-reference]
  508 |     for (auto operand : adaptor.getOperands().front()) {
      |                                                     ^
/home/buildbot/worker/as-builder-7/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/XeGPU/Transforms/XeGPUWgToSgDistribute.cpp:508:52: note: the temporary was destroyed at the end of the full expression ‘adaptor.mlir::vector::BroadcastOpGenericAdaptor<llvm::ArrayRef<mlir::ValueRange> >::getOperands().llvm::ArrayRef<mlir::ValueRange>::front()’
  508 |     for (auto operand : adaptor.getOperands().front()) {

```

</details>

https://github.com/llvm/llvm-project/pull/157374