[Mlir-commits] [mlir] 96195e7 - [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in Transport.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Sun Sep 7 11:17:33 PDT 2025


Author: Mehdi Amini
Date: 2025-09-07T10:55:50-07:00
New Revision: 96195e7d44613e272475c90df187678036f21966

URL: https://github.com/llvm/llvm-project/commit/96195e7d44613e272475c90df187678036f21966
DIFF: https://github.com/llvm/llvm-project/commit/96195e7d44613e272475c90df187678036f21966.diff

LOG: [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in Transport.cpp (NFC)

Added: 
    

Modified: 
    mlir/unittests/Tools/lsp-server-support/Transport.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/unittests/Tools/lsp-server-support/Transport.cpp b/mlir/unittests/Tools/lsp-server-support/Transport.cpp
index cdfc1c12141e2..92581bd2bad08 100644
--- a/mlir/unittests/Tools/lsp-server-support/Transport.cpp
+++ b/mlir/unittests/Tools/lsp-server-support/Transport.cpp
@@ -147,7 +147,7 @@ TEST_F(TransportInputTest, OutgoingRequest) {
   auto callFn =
       getMessageHandler().outgoingRequest<CompletionList, CompletionContext>(
           "outgoing-request",
-          [&responseCallbackInvoked](llvm::json::Value id,
+          [&responseCallbackInvoked](const llvm::json::Value &id,
                                      llvm::Expected<CompletionContext> result) {
             // Make expectations on the expected response.
             EXPECT_EQ(id, 83);
@@ -177,7 +177,7 @@ TEST_F(TransportInputTest, OutgoingRequestJSONParseFailure) {
   bool responseCallbackInvoked = false;
   auto callFn = getMessageHandler().outgoingRequest<CompletionList, Position>(
       "outgoing-request-json-parse-failure",
-      [&responseCallbackInvoked](llvm::json::Value id,
+      [&responseCallbackInvoked](const llvm::json::Value &id,
                                  llvm::Expected<Position> result) {
         llvm::Error err = result.takeError();
         EXPECT_EQ(id, 109);


        


More information about the Mlir-commits mailing list