[Mlir-commits] [mlir] fc505d0 - [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in ScalableValueBoundsConstraintSet.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2025-09-04T11:22:14-07:00
New Revision: fc505d08a32993b132a81851fa023b78d93fcca0

URL: https://github.com/llvm/llvm-project/commit/fc505d08a32993b132a81851fa023b78d93fcca0
DIFF: https://github.com/llvm/llvm-project/commit/fc505d08a32993b132a81851fa023b78d93fcca0.diff

LOG: [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in ScalableValueBoundsConstraintSet.cpp (NFC)

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.h
    mlir/lib/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.h b/mlir/include/mlir/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.h
index 93b3c92533c54..216b94fc445c7 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.h
+++ b/mlir/include/mlir/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.h
@@ -72,7 +72,7 @@ struct ScalableValueBoundsConstraintSet
   computeScalableBound(Value value, std::optional<int64_t> dim,
                        unsigned vscaleMin, unsigned vscaleMax,
                        presburger::BoundType boundType, bool closedUB = true,
-                       StopConditionFn stopCondition = nullptr);
+                       const StopConditionFn &stopCondition = nullptr);
 
   /// Get the value of vscale. Returns `nullptr` vscale as not been encountered.
   Value getVscaleValue() const { return vscale; }

diff  --git a/mlir/lib/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.cpp b/mlir/lib/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.cpp
index 7b9e51a01a946..4b749004622df 100644
--- a/mlir/lib/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.cpp
+++ b/mlir/lib/Dialect/Vector/IR/ScalableValueBoundsConstraintSet.cpp
@@ -43,7 +43,7 @@ FailureOr<ConstantOrScalableBound>
 ScalableValueBoundsConstraintSet::computeScalableBound(
     Value value, std::optional<int64_t> dim, unsigned vscaleMin,
     unsigned vscaleMax, presburger::BoundType boundType, bool closedUB,
-    StopConditionFn stopCondition) {
+    const StopConditionFn &stopCondition) {
   using namespace presburger;
   assert(vscaleMin <= vscaleMax);