[Mlir-commits] [mlir] [mlir][emitc] Add 'emitc.while' and 'emitc.do' ops to the dialect (PR #143008)

[Gil Rapaport]

aniragil wrote:

> @aniragil, gentle ping. I've corrected the code based on the discussion above — removed lovering from `scf.while` to `emitc.while`.

Thanks for the ping!
As (I think) we discussed in the comments, the patch now introduces a dead `emitc.while` op, which it shouldn't. It should be commited along with the pass that transforms `emitc.do` into `emitc.while` as discussed. I'd do that it in a separate patch to first get the canonical scf lowering in (but if you prefer to add it here I guess that's fine too).

https://github.com/llvm/llvm-project/pull/143008