[Mlir-commits] [mlir] [mlir][LLVM|ptr] Add the `#llvm.address_space` attribute, and allow `ptr` translation (PR #156333)

[Mehdi Amini]

================
@@ -43,6 +43,7 @@ def MemorySpaceAttrInterface : AttrInterface<"MemorySpaceAttrInterface"> {
       /*args=*/        (ins "::mlir::Type":$type,
                             "::mlir::ptr::AtomicOrdering":$ordering,
                             "std::optional<int64_t>":$alignment,
+                            "std::optional<std::reference_wrapper<const ::mlir::DataLayout>>":$dataLayout,
----------------
joker-eph wrote:

That seems uncommon in the codebase, the usual idiom for an optional thing would be to take a pointer:

```suggestion
                            "const ::mlir::DataLayout *":$dataLayout,
```

https://github.com/llvm/llvm-project/pull/156333