[Mlir-commits] [mlir] [mlir][tosa] Apply 'Symbol' trait to `tosa.variable` (PR #153223)

[Luke Hutton]

================
@@ -105,14 +109,18 @@ def Tosa_VariableOp : Tosa_Op<"variable", []> {
   let hasCustomAssemblyFormat = 1;
 
   let assemblyFormat = [{
-    $name
+    $sym_name
     attr-dict
     custom<VariableOpTypeOrInitialValue>($var_shape, $type, $initial_value)
   }];
 
   let builders = [Tosa_VariableOpBuilder];
 
-  let hasVerifier = 1;
+  let extraClassDeclaration = [{
----------------
lhutton1 wrote:

This change was to avoid breaking dependent code that might have previously relied on `getName()` (before the renaming). In theory, we could avoid providing this and make it clear in the PR that this is a breaking change

https://github.com/llvm/llvm-project/pull/153223