[Mlir-commits] [mlir] [MLIR] Split ExecutionEngine Initialization out of ctor into an explicit method call (PR #153524)

[Rainer Orth]

rorth wrote:

This test `FAIL`s on Solaris/sparcv9:
```
  MLIR-Unit :: ExecutionEngine/./MLIRExecutionEngineTests/6/7

Note: This is test shard 7 of 7.
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MLIRExecutionEngine
[ DISABLED ] MLIRExecutionEngine.DISABLED_AddInteger
[ DISABLED ] MLIRExecutionEngine.DISABLED_SubtractFloat
[ RUN      ] MLIRExecutionEngine.MAYBE_JITCallbackInGlobalCtor
/vol/llvm/src/llvm-project/local/mlir/unittests/ExecutionEngine/Invoke.cpp:356: Failure
Value of: !!jitOrError
  Actual: false
Expected: true

Expected<T> must be checked before access or destruction.
Unchecked Expected<T> contained error:
Target has no JIT supportStack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  MLIRExecutionEngineTests 0x0000000105005750 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 36
1  MLIRExecutionEngineTests 0x0000000105006484 SignalHandler(int, siginfo*, void*) + 852
2  libc.so.1                0xffffffff7edc6da8 __sighndlr + 12
3  libc.so.1                0xffffffff7edb96f0 call_user_handler + 864
4  libc.so.1                0xffffffff7edb9a50 sigacthandler + 80
5  libc.so.1                0xffffffff7edcbee0 __lwp_sigqueue + 8
6  libc.so.1                0xffffffff7ece965c abort + 252
7  MLIRExecutionEngineTests 0x0000000104f09158 llvm::Expected<std::unique_ptr<mlir::ExecutionEngine, std::default_delete<mlir::ExecutionEngine>>>::fatalUncheckedExpected() const + 308
8  MLIRExecutionEngineTests 0x0000000104f08754 MLIRExecutionEngine_MAYBE_JITCallbackInGlobalCtor_Test::TestBody() + 3120
9  MLIRExecutionEngineTests 0x000000010503335c testing::Test::Run() + 432
10 MLIRExecutionEngineTests 0x00000001050349a8 testing::TestInfo::Run() + 484
11 MLIRExecutionEngineTests 0x00000001050359a8 testing::TestSuite::Run() + 1168
12 MLIRExecutionEngineTests 0x0000000105047520 testing::internal::UnitTestImpl::RunAllTests() + 2688
13 MLIRExecutionEngineTests 0x0000000105046914 testing::UnitTest::Run() + 128
14 MLIRExecutionEngineTests 0x00000001050168b8 main + 168
15 MLIRExecutionEngineTests 0x0000000104ef36c4 _start + 100

--
exit: -6
```
I suspect this happens bacause there's no JIT support on SPARC.

https://github.com/llvm/llvm-project/pull/153524