[Mlir-commits] [flang] [mlir] [acc][flang] Implement OpenACC interface for partial entity accesses (PR #165911)

[Razvan Lupusoru]

================
@@ -2828,7 +2829,8 @@ def fir_VolatileCastOp : fir_SimpleOneResultOp<"volatile_cast", [Pure]> {
   let hasFolder = 1;
 }
 
-def fir_ConvertOp : fir_SimpleOneResultOp<"convert", [NoMemoryEffect]> {
+def fir_ConvertOp
+    : fir_SimpleOneResultOp<"convert", [NoMemoryEffect, ViewLikeOpInterface]> {
----------------
razvanlupusoru wrote:

Ah! I am testing with this change because I need to be able to walk past `fir.convert` operations. Those are not clearly "partial" views so hence my interface was not appropriate to attach to those - so I am attaching ViewLikeOpInterface instead like you did in your ViewLikeOpInterface implementation for FIR. I could break it up to a follow-up change if you prefer - but sounds like you're OK I am including it here since it is a few small changes. :) Thanks!

https://github.com/llvm/llvm-project/pull/165911