[Mlir-commits] [mlir] a8abf81 - [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in ViewOpGraph.cpp (NFC)
Mehdi Amini
llvmlistbot at llvm.org
Thu Oct 30 21:44:43 PDT 2025
Author: Mehdi Amini
Date: 2025-10-30T21:44:21-07:00
New Revision: a8abf813eb30c06bb3b91965b9818462ebc25855
URL: https://github.com/llvm/llvm-project/commit/a8abf813eb30c06bb3b91965b9818462ebc25855
DIFF: https://github.com/llvm/llvm-project/commit/a8abf813eb30c06bb3b91965b9818462ebc25855.diff
LOG: [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in ViewOpGraph.cpp (NFC)
Added:
Modified:
mlir/lib/Transforms/ViewOpGraph.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Transforms/ViewOpGraph.cpp b/mlir/lib/Transforms/ViewOpGraph.cpp
index 08cac1fe3695c..5790a77cc4e2b 100644
--- a/mlir/lib/Transforms/ViewOpGraph.cpp
+++ b/mlir/lib/Transforms/ViewOpGraph.cpp
@@ -158,7 +158,8 @@ class PrintOpPass : public impl::ViewOpGraphBase<PrintOpPass> {
/// Emit a cluster (subgraph). The specified builder generates the body of the
/// cluster. Return the anchor node of the cluster.
- Node emitClusterStmt(function_ref<void()> builder, std::string label = "") {
+ Node emitClusterStmt(function_ref<void()> builder,
+ const std::string &label = "") {
int clusterId = ++counter;
os << "subgraph cluster_" << clusterId << " {\n";
os.indent();
@@ -269,7 +270,7 @@ class PrintOpPass : public impl::ViewOpGraphBase<PrintOpPass> {
}
/// Emit a node statement.
- Node emitNodeStmt(std::string label, StringRef shape = kShapeNode,
+ Node emitNodeStmt(const std::string &label, StringRef shape = kShapeNode,
StringRef background = "") {
int nodeId = ++counter;
AttributeMap attrs;
More information about the Mlir-commits
mailing list