[Mlir-commits] [mlir] [mlir][GPU][NFC] adds TODO messages for amdgpu-specific pattern relocation (PR #165812)

[llvmlistbot at llvm.org]

https://github.com/Muzammiluddin-Syed-ECE created https://github.com/llvm/llvm-project/pull/165812

Adds TODO messages to signal future work to move misplaced patterns, see https://github.com/llvm/llvm-project/issues/165811.

>From bf5e296338b0773ce29b5168d9fe52815139dff9 Mon Sep 17 00:00:00 2001
From: Muzammil <55665739+Muzammiluddin-Syed-ECE at users.noreply.github.com>
Date: Thu, 30 Oct 2025 21:10:55 -0400
Subject: [PATCH 1/2] [mlir][GPU][NFC] add TODO message for amdgpu-specific
 pattern relocation

---
 mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp b/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
index 81c3069cec16e..8c1f54b800089 100644
--- a/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp
@@ -367,6 +367,8 @@ struct VectorSubgroupReduceToShuffles final
   bool matchClustered = false;
 };
 
+// TODO: Move amdgpu specific patterns out of GPU dialect (#165811).
+
 static FailureOr<Value>
 createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp op,
                            Value input, gpu::AllReduceOperation mode,

>From 3d19f35c28b70214041efde34364c545aa02afb2 Mon Sep 17 00:00:00 2001
From: Muzammil <55665739+Muzammiluddin-Syed-ECE at users.noreply.github.com>
Date: Thu, 30 Oct 2025 21:13:10 -0400
Subject: [PATCH 2/2] [mlir][GPU][NFC] add TODO message for amdgpu-specific
 pattern relocation

---
 mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp b/mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp
index 67cef8af1e3b5..f27565e04b48b 100644
--- a/mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp
@@ -26,6 +26,8 @@ namespace {
 
 constexpr amdgpu::Chipset kGfx950 = amdgpu::Chipset(9, 5, 0);
 
+// TODO: Move amdgpu specific patterns out of GPU dialect (#165811).
+
 /// Try to promote `gpu.shuffle` to `amdgpu.swizzle_bitmode`, width must be 64
 /// and offset must be a constant integer in the range [0, 31].
 struct PromoteShuffleToSwizzlePattern