[Mlir-commits] [mlir] [mlir][sparse] Include sparse emit strategy in wrapping iterator (PR #165611)
Jordan Rupprecht
llvmlistbot at llvm.org
Wed Oct 29 13:39:53 PDT 2025
rupprecht wrote:
Thanks!
> If this fixes an UB, then it is arguably no longer an NFC, right? [I am not 100% sure about our terminology]. In any case, thanks for fixing.
I've heard a wide range of opinions for what's considered NFC. This patch feels NFC to me because, outside of the UB issue, nothing should be changing. But I can totally see how removing UB is not NFC. I'll err on the side of not claiming this is NFC.
https://github.com/llvm/llvm-project/pull/165611
More information about the Mlir-commits
mailing list