[Mlir-commits] [mlir] [mlir][linalg] Do not set insertion point inside padding function (PR #165420)
Kunwar Grover
llvmlistbot at llvm.org
Wed Oct 29 05:26:41 PDT 2025
Groverkss wrote:
> The expectation that the caller is the one setting the insertion point is already how things like rewrite patterns work, so conceptually LGTM.
>
> Please add a comment documenting this is the expectation, also there's a build error because there's a transform not setting the insertion point.
Done, I'm guessing since you only had minor comments, it's okay to land. If there are any further comments, happy to address them in a post commit review.
https://github.com/llvm/llvm-project/pull/165420
More information about the Mlir-commits
mailing list