[Mlir-commits] [mlir] [MLIR][EmitC] Add support for pointer-array types in the TypeConverter and related MemRef-to-EmitC operations, and update the C emitter. (PR #160159)

[Matthias Gehre]

================
@@ -51,9 +57,15 @@ module @globals {
   // CHECK-LABEL: use_global
   func.func @use_global() {
     // CHECK-NEXT: emitc.get_global @public_global : !emitc.array<3x7xf32>
+    // CHECK-NEXT: "emitc.constant"() <{value = 0 : index}> : () -> index
----------------
mgehre-amd wrote:

We depend on the simpler memref = emitc.array conversion downstream. Can we keep that as an option? The new way of type conversion introduces multiple additional ops and I don't see the benefit for us. What was the issue that this is solving?

https://github.com/llvm/llvm-project/pull/160159