[Mlir-commits] [mlir] [mlir][tosa] Add support for mxint8 type in mxfp operations (PR #163642)

[Peng Sun]

================
@@ -1217,9 +1217,10 @@ bool TosaValidation::isValidElementType(Type type, const bool allowUnsigned) {
         return true;
       }
     }
-  } else if (mlir::isa<tosa::shapeType>(type)) {
+  } else if (mlir::isa<tosa::shapeType>(type))
----------------
psunn wrote:

NIT: this type check for `tosa::shapeType` is inconsistent with the rest of the function, which uses isa<...>(type)

https://github.com/llvm/llvm-project/pull/163642