[Mlir-commits] [mlir] [MLIR] Fix use-after-move for DEBUG builds, and broken assert logic. (PR #164763)

[Slava Gurevich]

================
@@ -159,14 +159,19 @@ IterationGraphSorter::IterationGraphSorter(
       loop2OutLvl(loop2OutLvl), iterTypes(std::move(iterTypes)),
       strategy(strategy) {
----------------
noclowns wrote:

I don't disagree with you. My point was that In terms of risk, a change to the signature vs a fully-local change always requires a greater consideration of potential side-effects because of the wider exposure, i.e. what and how it affects in terms of its consumers. It could be as subtle as some tool-generated metadata (doxygen etc), or simply making other (code client) developers unnecessarily more aware of the change. Also, it's a change to 2 files vs 1 file, and some extra effort on what to rename the args to, and whether to rename all args or just the affected ones. That by itself is likely to trigger opinions in PR review. I enjoy discussing these nuances, and if you like we can connect to chat about these topics offline. Thanks again.

Could you then take a look to see if the arg renaming looks OK to you stylistically? 
https://github.com/llvm/llvm-project/pull/165208

https://github.com/llvm/llvm-project/pull/164763