[Mlir-commits] [mlir] ceed42a - [MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in SimplexTest.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2025-10-27T22:22:54-07:00
New Revision: ceed42ae3de5d8bbb3d8697e4f86e95cf4e14455

URL: https://github.com/llvm/llvm-project/commit/ceed42ae3de5d8bbb3d8697e4f86e95cf4e14455
DIFF: https://github.com/llvm/llvm-project/commit/ceed42ae3de5d8bbb3d8697e4f86e95cf4e14455.diff

LOG: [MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in SimplexTest.cpp (NFC)

Added: 
    

Modified: 
    mlir/unittests/Analysis/Presburger/SimplexTest.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/unittests/Analysis/Presburger/SimplexTest.cpp b/mlir/unittests/Analysis/Presburger/SimplexTest.cpp
index 63d0243808555..0955efdf2e988 100644
--- a/mlir/unittests/Analysis/Presburger/SimplexTest.cpp
+++ b/mlir/unittests/Analysis/Presburger/SimplexTest.cpp
@@ -20,26 +20,29 @@ using namespace mlir;
 using namespace presburger;
 
 /// Convenience functions to pass literals to Simplex.
-void addInequality(SimplexBase &simplex, ArrayRef<int64_t> coeffs) {
+static void addInequality(SimplexBase &simplex, ArrayRef<int64_t> coeffs) {
   simplex.addInequality(getDynamicAPIntVec(coeffs));
 }
-void addEquality(SimplexBase &simplex, ArrayRef<int64_t> coeffs) {
+static void addEquality(SimplexBase &simplex, ArrayRef<int64_t> coeffs) {
   simplex.addEquality(getDynamicAPIntVec(coeffs));
 }
-bool isRedundantInequality(Simplex &simplex, ArrayRef<int64_t> coeffs) {
+static bool isRedundantInequality(Simplex &simplex, ArrayRef<int64_t> coeffs) {
   return simplex.isRedundantInequality(getDynamicAPIntVec(coeffs));
 }
-bool isRedundantInequality(LexSimplex &simplex, ArrayRef<int64_t> coeffs) {
+static bool isRedundantInequality(LexSimplex &simplex,
+                                  ArrayRef<int64_t> coeffs) {
   return simplex.isRedundantInequality(getDynamicAPIntVec(coeffs));
 }
-bool isRedundantEquality(Simplex &simplex, ArrayRef<int64_t> coeffs) {
+static bool isRedundantEquality(Simplex &simplex, ArrayRef<int64_t> coeffs) {
   return simplex.isRedundantEquality(getDynamicAPIntVec(coeffs));
 }
-bool isSeparateInequality(LexSimplex &simplex, ArrayRef<int64_t> coeffs) {
+static bool isSeparateInequality(LexSimplex &simplex,
+                                 ArrayRef<int64_t> coeffs) {
   return simplex.isSeparateInequality(getDynamicAPIntVec(coeffs));
 }
 
-Simplex::IneqType findIneqType(Simplex &simplex, ArrayRef<int64_t> coeffs) {
+static Simplex::IneqType findIneqType(Simplex &simplex,
+                                      ArrayRef<int64_t> coeffs) {
   return simplex.findIneqType(getDynamicAPIntVec(coeffs));
 }
 
@@ -81,8 +84,9 @@ TEST(SimplexTest, addEquality_separate) {
   EXPECT_TRUE(simplex.isEmpty());
 }
 
-void expectInequalityMakesSetEmpty(Simplex &simplex, ArrayRef<int64_t> coeffs,
-                                   bool expect) {
+static void expectInequalityMakesSetEmpty(Simplex &simplex,
+                                          ArrayRef<int64_t> coeffs,
+                                          bool expect) {
   ASSERT_FALSE(simplex.isEmpty());
   unsigned snapshot = simplex.getSnapshot();
   addInequality(simplex, coeffs);
@@ -121,9 +125,9 @@ TEST(SimplexTest, addInequality_rollback) {
   }
 }
 
-Simplex simplexFromConstraints(unsigned nDim,
-                               ArrayRef<SmallVector<int64_t, 8>> ineqs,
-                               ArrayRef<SmallVector<int64_t, 8>> eqs) {
+static Simplex simplexFromConstraints(unsigned nDim,
+                                      ArrayRef<SmallVector<int64_t, 8>> ineqs,
+                                      ArrayRef<SmallVector<int64_t, 8>> eqs) {
   Simplex simplex(nDim);
   for (const auto &ineq : ineqs)
     addInequality(simplex, ineq);