[Mlir-commits] [mlir] [MLIR] Fix use-after-move for DEBUG builds, and broken assert logic. (PR #164763)

[Slava Gurevich]

================
@@ -159,14 +159,19 @@ IterationGraphSorter::IterationGraphSorter(
       loop2OutLvl(loop2OutLvl), iterTypes(std::move(iterTypes)),
       strategy(strategy) {
----------------
noclowns wrote:

A tool won't complain about the call-sites, but it can be confusing for humans(readability and maintainability). clang-tidy could complain if the declaration and definition names don't match, because it's error-prone (for humans). The compiler would be happy either way. You bring up a good point that the constructor is private. I have merged the PR already, but can to go back and revise by changing the arg names. Or can do a follow up clean up in the upcoming PRs. What would you prefer? Thank you for your robust review, by the way.

https://github.com/llvm/llvm-project/pull/164763