[Mlir-commits] [mlir] [MLIR] Fix use-after-move for DEBUG builds, and broken assert logic. (PR #164763)

[Slava Gurevich]

================
@@ -159,14 +159,19 @@ IterationGraphSorter::IterationGraphSorter(
       loop2OutLvl(loop2OutLvl), iterTypes(std::move(iterTypes)),
       strategy(strategy) {
----------------
noclowns wrote:

If the ctor args are renamed, then the class' declaration in a separate .h file should likely too be updated (as discussed the in the previous comment). Then it is no longer a fully-localized change, and has at least some negative effect  -- code devs often use the matching variable names at the call site, that would now diverge between the old and the new code, and then there's the divergence between the old vs new documentation autogenerated by doxygen. Even if these are minor concerns, they swayed me towards a fully-localized code change that was available and is idiomatic. But I don't mind implementing a different approach If there's a strong preference.

https://github.com/llvm/llvm-project/pull/164763