[Mlir-commits] [mlir] [mlir][linalg] Update vectorization of linalg.pack (PR #163539)

[Andrzej Warzyński]

================
@@ -37,7 +37,8 @@ namespace linalg {
 /// This function uses the helper function `computePackUnPackPerm` to get
 /// the permutation vector. Only major difference between UnPack and Pack is
 /// that packOp uses destination rank whereas unpack Uses source rank.
-SmallVector<int64_t> getPackInverseDestPerm(linalg::PackOp packOp);
+SmallVector<int64_t> getPackInverseDestPerm(linalg::PackOp packOp,
+                                            PackingMetadata &metadatap);
----------------
banach-space wrote:

Sorry, that's a typo. Let me update this to match `getUnPackInverseSrcPerm`. I will also update the docs for both hooks - in fact, I will make them much shorter. Right now, IMHO, they are too long and go into implementation details that should be left for the implementation itself: https://github.com/llvm/llvm-project/blob/71b21b5391b267f10c8222fbbe73494fbce6dd86/mlir/include/mlir/Dialect/Linalg/Utils/Utils.h#L36-L39

I will also remove this helper hook which doesn't seem to be required (at least based on "upstream"):
https://github.com/llvm/llvm-project/blob/71b21b5391b267f10c8222fbbe73494fbce6dd86/mlir/include/mlir/Dialect/Linalg/Utils/Utils.h#L47

https://github.com/llvm/llvm-project/pull/163539