[Mlir-commits] [mlir] [mlir][linalg] Update vectorization of linalg.pack (PR #163539)

[Han-Chung Wang]

================
@@ -37,7 +37,8 @@ namespace linalg {
 /// This function uses the helper function `computePackUnPackPerm` to get
 /// the permutation vector. Only major difference between UnPack and Pack is
 /// that packOp uses destination rank whereas unpack Uses source rank.
-SmallVector<int64_t> getPackInverseDestPerm(linalg::PackOp packOp);
+SmallVector<int64_t> getPackInverseDestPerm(linalg::PackOp packOp,
+                                            PackingMetadata &metadatap);
----------------
hanhanW wrote:

pMetadata? It does not match the implementation; I think `packingMetadata` looks better, as you are exposing it as a function argument. Or it can just be `metadata` like the other function, i.e. getUnPackInverseSrcPerm. The doc needs to be updated as well.

https://github.com/llvm/llvm-project/pull/163539