[Mlir-commits] [mlir] [MLIR][Vector] Add unroll pattern for vector.shape_cast (PR #164010)

[Nishant Patel]

nbpatel wrote:

> Hey, thanks for sending this!
> 
> Sorry for not noticing/asking earlier, but how does this differ from https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Vector/Transforms/LowerVectorShapeCast.cpp? It looks super-similar.
> 
> I am not against this change, but do want to avoid duplication. If both transformations are needed, then there should be some functionality provided by one of these that cannot be provided by the other, no?

Hi @banach-space , my understanding is that ShapeCastOpRewritePattern works directly with the full transformation but Unrolling works in target-sized tiles (2x2), then assembles them. I also see there are similar patterns for other ops as well like BroadcastOpLowering (LowerBroadcastOp.cpp) and UnrollBroadcast. 

https://github.com/llvm/llvm-project/pull/164010