[Mlir-commits] [mlir] 90b51c3 - [MLIR][ExecutionEngine] don't leak -Wweak-vtables (#164498)

[llvmlistbot at llvm.org]

Author: Maksim Levental
Date: 2025-10-23T06:41:02-07:00
New Revision: 90b51c393905eb82eb882d7a1d5bb999dc67a74b

URL: https://github.com/llvm/llvm-project/commit/90b51c393905eb82eb882d7a1d5bb999dc67a74b
DIFF: https://github.com/llvm/llvm-project/commit/90b51c393905eb82eb882d7a1d5bb999dc67a74b.diff

LOG: [MLIR][ExecutionEngine] don't leak -Wweak-vtables (#164498)

I'm not 100% what this is used for in this lib but the compile flag
leaks out and prevents (in certain compile scenarios) linking
`mlir_c_runner_utils`.

Added: 
    

Modified: 
    mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
index 6ef1529343453..c712c64b6de55 100644
--- a/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
+++ b/mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt
@@ -21,6 +21,6 @@ set_property(TARGET MLIRSparseTensorRuntime PROPERTY CXX_STANDARD 17)
 check_cxx_compiler_flag(-Wweak-vtables
   COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
 if(COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
-  target_compile_options(MLIRSparseTensorRuntime PUBLIC
+  target_compile_options(MLIRSparseTensorRuntime PRIVATE
     "-Wweak-vtables")
 endif()