[Mlir-commits] [mlir] [MLIR][Vector] Add unroll pattern for vector.shape_cast (PR #164010)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Hey, thanks for sending this!

Sorry for not noticing/asking earlier, but how does this differ from https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Vector/Transforms/LowerVectorShapeCast.cpp? It looks super-similar. 

I am not against this change, but do want to avoid duplication. If both transformations are needed, then there should be some functionality provided by one of these that cannot be provided by the other, no?

https://github.com/llvm/llvm-project/pull/164010