[Mlir-commits] [mlir] [MLIR][Vector] Support vector reduction for xor/maxnumf/minnumf (PR #163310)

[Lee Wei]

leewei05 wrote:

Tests for `minnumf`, `maxnumf`, `xor` ops are already added in:
https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/Vector/ops.mlir
https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/Vector/invalid.mlir#L1176
https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/Vector/break-down-vector-reduction.mlir#L19

As for conversion tests to LLVM, they are already in it.
https://github.com/llvm/llvm-project/blob/main/mlir/test/Conversion/VectorToLLVM/vector-reduction-to-llvm.mlir#L133

For conversion to SPIR-V, `xor` reduction op is missing. I'll add the implementation and tests in a separate PR. As for integration test, I'll create a follow-up PR as well.


https://github.com/llvm/llvm-project/pull/163310