[Mlir-commits] [mlir] [mlir][scf] Add parallelLoopUnrollByFactors() (PR #163806)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

Could you follow https://mlir.llvm.org/getting_started/TestingGuide/#example-improving-test-readability--naming (and that guideline in general) for writing tests? In particular:
* Update test function name to capture the edge case being tested (e.g. avoid using `test` in function names - it doesn't convey any unique info, you can also safely skip "unroll" and "parellel" - that's already encoded in the test file name).
* Use meaningful variable names (e.g. `%arg0` -> `%lb_0`)

Also, this file calls for more test cases :) Here's what comes to mind:
* Static bounds vs dynamic bounds
* Single loop vs nested loops.
* Some negative tests.

https://github.com/llvm/llvm-project/pull/163806