[Mlir-commits] [mlir] [mlir][spirv] Remove `function-decorations-asserts.mlir` (PR #164383)

Igor Wodiany llvmlistbot at llvm.org
Tue Oct 21 02:57:22 PDT 2025


https://github.com/IgWod-IMG created https://github.com/llvm/llvm-project/pull/164383

The test is fragile as it relies on the `--debug` flag to test an internal behaviour. This addresses discussion in #164319.

>From 28755d512a93c59c4428874d11943613e954969e Mon Sep 17 00:00:00 2001
From: Igor Wodiany <igor.wodiany at imgtec.com>
Date: Tue, 21 Oct 2025 10:38:26 +0100
Subject: [PATCH] [mlir][spirv] Remove `function-decorations-asserts.mlir`

The test is fragile as it relies on the `--debug` flag to test
an internal behaviour. This address discussion in #164319.
---
 .../SPIRV/function-decorations-asserts.mlir   | 20 -------------------
 1 file changed, 20 deletions(-)
 delete mode 100644 mlir/test/Target/SPIRV/function-decorations-asserts.mlir

diff --git a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir b/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
deleted file mode 100644
index ebdb9fb1e75e3..0000000000000
--- a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
+++ /dev/null
@@ -1,20 +0,0 @@
-// REQUIRES: asserts
-// RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file --debug %s | FileCheck %s
-
-spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> {
-    spirv.func @linkage_attr_test_kernel()  "DontInline"  attributes {}  {
-        %uchar_0 = spirv.Constant 0 : i8
-        %ushort_1 = spirv.Constant 1 : i16
-        %uint_0 = spirv.Constant 0 : i32
-        spirv.FunctionCall @outside.func.with.linkage(%uchar_0):(i8) -> ()
-        spirv.Return
-    }
-    // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outside.func", linkage_type = <Import>>
-    spirv.func @outside.func.with.linkage(%arg0 : i8) -> () "Pure" attributes {
-      linkage_attributes=#spirv.linkage_attributes<
-        linkage_name="outside.func",
-        linkage_type=<Import>
-      >
-    }
-    spirv.func @inside.func() -> () "Pure" attributes {} {spirv.Return}
-}



More information about the Mlir-commits mailing list