[Mlir-commits] [mlir] [MLIR][Vector] Support vector reduction for xor/maxnumf/minnumf (PR #163310)

[Lee Wei]

leewei05 wrote:

> TBH, you are hitting a pretty rare case. In principle, most tests relevant to `vector.reduction` should be updated, but then you would be penalised for our negligence in the past 😅 That's not needed IMHO, and Diego seems to agree (given his approval).
> 
> Hopefully this makes sense and you don't mind the extra work :)

@banach-space Thank you for the reply! I was following this commit https://github.com/llvm/llvm-project/commit/059ee5d9378d3abfcfd301f4d083ca399df2045e, so I thought the tests were sufficient. Anyways, I'll spend some time to cover enough tests for this PR. Thanks again!



https://github.com/llvm/llvm-project/pull/163310