[Mlir-commits] [mlir] [mlir][linalg] Genericize MapOp (PR #162742)

[llvmlistbot at llvm.org]

srcarroll wrote:

> A high level question - instead of changing linalg.map definition, would it not be less ruffling if instead you extended linalg-morph-ops with a pattern to rewrite linalg.map into generic?

In my opinion what you are suggesting is even more "ruffling".  These changes don't change the definition of map op. Nor does it have a negative impact on anything else as far as I can tell. A better question would be why have this specialization for the bbargs in the map op when all it does is make it harder to apply generic patterns that already exist? I'd like to hear one good reason to keep this specialization as is.


https://github.com/llvm/llvm-project/pull/162742