[Mlir-commits] [flang] [mlir] [flang][acc] Add recipe populate testing through type interfaces (PR #163990)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp b/mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
index a4931c30c..dcfe2c742 100644
--- a/mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
+++ b/mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
@@ -1224,7 +1224,7 @@ PrivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
   // Populate the init region
   bool needsFree = false;
   if (failed(createInitRegion(builder, loc, recipe.getInitRegion(), varType,
-                               varName, bounds, needsFree))) {
+                              varName, bounds, needsFree))) {
     recipe.erase();
     return std::nullopt;
   }
@@ -1232,12 +1232,12 @@ PrivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
   // Only create destroy region if the allocation needs deallocation
   if (needsFree) {
     // Extract the allocated value from the init block's yield operation
-    auto yieldOp = cast<acc::YieldOp>(
-        recipe.getInitRegion().front().getTerminator());
+    auto yieldOp =
+        cast<acc::YieldOp>(recipe.getInitRegion().front().getTerminator());
     Value allocRes = yieldOp.getOperand(0);
 
     if (failed(createDestroyRegion(builder, loc, recipe.getDestroyRegion(),
-                                    varType, allocRes, bounds))) {
+                                   varType, allocRes, bounds))) {
       recipe.erase();
       return std::nullopt;
     }
@@ -1296,14 +1296,14 @@ FirstprivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
   // Populate the init region
   bool needsFree = false;
   if (failed(createInitRegion(builder, loc, recipe.getInitRegion(), varType,
-                               varName, bounds, needsFree))) {
+                              varName, bounds, needsFree))) {
     recipe.erase();
     return std::nullopt;
   }
 
   // Populate the copy region
   if (failed(createCopyRegion(builder, loc, recipe.getCopyRegion(), varType,
-                               bounds))) {
+                              bounds))) {
     recipe.erase();
     return std::nullopt;
   }
@@ -1311,12 +1311,12 @@ FirstprivateRecipeOp::createAndPopulate(OpBuilder &builder, Location loc,
   // Only create destroy region if the allocation needs deallocation
   if (needsFree) {
     // Extract the allocated value from the init block's yield operation
-    auto yieldOp = cast<acc::YieldOp>(
-        recipe.getInitRegion().front().getTerminator());
+    auto yieldOp =
+        cast<acc::YieldOp>(recipe.getInitRegion().front().getTerminator());
     Value allocRes = yieldOp.getOperand(0);
 
     if (failed(createDestroyRegion(builder, loc, recipe.getDestroyRegion(),
-                                    varType, allocRes, bounds))) {
+                                   varType, allocRes, bounds))) {
       recipe.erase();
       return std::nullopt;
     }

``````````

</details>


https://github.com/llvm/llvm-project/pull/163990